Add a test to track @experimental definitions #14944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
add-experimental-checks
branch
2 times, most recently
from
9eede77 to
46080e4
Compare
Label all definition and add coments on when they can be stabilized
nicolasstucki
force-pushed
the
add-experimental-checks
branch
from
46080e4 to
3f642da
Compare
nicolasstucki
requested review from
anatoliykmetyuk and
smarter
and removed request for
anatoliykmetyuk
smarter
approved these changes
Apr 19, 2022
Comment on lines
+74
to
+78
| // Cant be stabilized yet. | ||
| // Need newClass variant that can add constructor parameters. | ||
| // Need experimental annotation macros to check that design works. | ||
| "scala.quoted.Quotes.reflectModule.ClassDefModule.apply", | ||
| "scala.quoted.Quotes.reflectModule.SymbolModule.newClass", |
There was a problem hiding this comment.
I guess this will need to be discussed, but if we want Scala 3.2 to be an LTS, we'll want to have these APIs stabilized by then. I don't think they preclude future additions that will benefit annotation macros.
There was a problem hiding this comment.
All these comments are subject to change in the LTS discussions. I just added the constraints/concerns we had discussed so far so that I am not the only one that knows them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Label all definitions and add comments on when they can be stabilized.
The purpose of this test is to make sure an experimental definition does not become stable accidentally. It is also a good place to check the list of methods that need to become stable in the next release.